PR for #142: Correct issue with eps file closing#143
Merged
Conversation
liaochris
changed the title
jmshapir
approved these changes
Mar 21, 2026
Contributor
jmshapir
left a comment
jmshapir
left a comment
There was a problem hiding this comment.
@liaochris looks good to me!
I'd like to have a second review.
I've invited @simonessigaberg to the repository following #53 (comment).
Once @simonessigaberg accepts the invite can you add @simonessigaberg as reviewer?
Thanks!
simonessigaberg
approved these changes
Mar 21, 2026
Collaborator
simonessigaberg
left a comment
simonessigaberg
left a comment
There was a problem hiding this comment.
@liaochris this looks good to me, thanks.
Collaborator
Author
|
Thanks for closing this pull. Before leaving the pull, please be sure you have completed all the required steps in the workflow. This includes filling in the issue summary linked at the top of this comment. |
liaochris
added a commit
that referenced
this pull request
Mar 25, 2026
This reverts commit f51a10f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue corrects a bug where we didn't successfully close eps files prior to writing to them.